chore(auth): legacy credential provider to use AuthOutputs instead of AmplifyConfig types #5303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
previously approved these changes
Aug 22, 2024
… AmplifyConfig types
NikaHsn
force-pushed
the
chore/auth/legacy-credential-provider
branch
from
ecd7a0c to
90a7f7e
Compare
| String username, | ||
| AuthOutputs authOutputs, | ||
| ) async { | ||
| if (authOutputs.userPoolClientId == null) return null; |
There was a problem hiding this comment.
suggestion: Remove the force casts. If you create variables for userPoolId and userPoolClientId and return early if they are null, then Dart will not require the force case.
final userPoolId = authOutputs.userPoolId;
final userPoolClientId = authOutputs.userPoolClientId;
if (userPoolId == null || userPoolClientId == null) return null;
final userPoolStorage = await _getUserPoolStorage();
final cognitoUserKeys = LegacyCognitoUserKeys(userPoolClientId);
final currentUserId = await userPoolStorage.read(
key: cognitoUserKeys[LegacyCognitoKey.currentUser],
);
if (currentUserId == null) return null;
final keys = LegacyDeviceSecretKeys(currentUserId, userPoolId);There was a problem hiding this comment.
This applies to several other locations in the PR.
| if (currentUserId == null) return; | ||
| final keys = LegacyDeviceSecretKeys(currentUserId, userPoolConfig); | ||
| final asfKeys = LegacyAsfDeviceKeys(currentUserId, userPoolConfig); | ||
| if (currentUserId == null || authOutputs.userPoolId == null) return; |
There was a problem hiding this comment.
Same suggestion as above. Remove the force cast by creating a userPoolId var.
| final currentUser = await userPoolStorage.read( | ||
| key: cognitoUserKeys[LegacyCognitoKey.currentUser], | ||
| ); | ||
| if (currentUser != null) { | ||
| final userPoolKeys = LegacyCognitoUserPoolKeys( | ||
| currentUser, | ||
| userPoolConfig, | ||
| authOutputs.userPoolClientId!, |
There was a problem hiding this comment.
See suggestion below about remove force casts
NikaHsn
force-pushed
the
chore/auth/legacy-credential-provider
branch
from
a09c772 to
de14ec5
Compare
NikaHsn
force-pushed
the
chore/auth/legacy-credential-provider
branch
from
de14ec5 to
1ea7f5f
Compare
Equartey
approved these changes
Sep 16, 2024
khatruong2009
approved these changes
Sep 16, 2024
Equartey
pushed a commit
that referenced
this pull request
Oct 21, 2024
… AmplifyConfig types (#5303)
Equartey
pushed a commit
that referenced
this pull request
Oct 21, 2024
… AmplifyConfig types (#5303)
Equartey
pushed a commit
that referenced
this pull request
Oct 22, 2024
… AmplifyConfig types (#5303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.